Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 11412177: Merge 135316 - When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/dom/DocumentStyleSheetCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 135773)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,21 @@
+2012-11-20 Tony Chang <tony@chromium.org>
+
+ When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
+ https://bugs.webkit.org/show_bug.cgi?id=102835
+
+ Reviewed by Ojan Vafai.
+
+ After r135082, Chromium browser_tests were triggering the ASSERT in
+ StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
+ trigger earlier and make it clear in the Chromium code that we're always
+ inserting user level styles.
+
+ No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
+ in Chromium browser_tests.
+
+ * dom/DocumentStyleSheetCollection.cpp:
+ (WebCore::DocumentStyleSheetCollection::addUserSheet):
+
2012-11-18 Antti Koivisto <antti@apple.com>
REGRESSION(r129644): User StyleSheet not applying
« no previous file with comments | « no previous file | Source/WebCore/dom/DocumentStyleSheetCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698