Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: base/android/path_utils_unittest.cc

Issue 11412128: Android: Fix PathUtilsTest.TestGetNativeLibraryDirectory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/path_utils_unittest.cc
diff --git a/base/android/path_utils_unittest.cc b/base/android/path_utils_unittest.cc
index 92728b5f6e0e6e6236644eb43363105777859f66..ede51144c0572837bc62ee6e91069b8e01bc5271 100644
--- a/base/android/path_utils_unittest.cc
+++ b/base/android/path_utils_unittest.cc
@@ -4,6 +4,7 @@
#include "base/android/path_utils.h"
#include "base/file_path.h"
+#include "base/file_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -38,8 +39,15 @@ TEST_F(PathUtilsTest, TestGetNativeLibraryDirectory) {
// org.chromium.native_test
FilePath path;
GetNativeLibraryDirectory(&path);
- EXPECT_STREQ("/data/data/org.chromium.native_test/lib",
- path.value().c_str());
+ // The exact location of the native library will depend on Android
+ // implementation. We just check that there is at least one .so
+ // in the returned directory.
+ file_util::FileEnumerator enumerator(
+ path,
+ false,
+ file_util::FileEnumerator::FILES,
+ "*.so");
bulach 2012/11/21 12:04:48 maybe best to check that it contains at least libb
+ EXPECT_FALSE(enumerator.Next().empty());
}
} // namespace android
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698