Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 11412117: Add intro to any Chrome app API that has nothing in place already. (Closed)

Created:
8 years, 1 month ago by mkearney1
Modified:
8 years ago
Reviewers:
miket_OOO, saroop, saroop
Visibility:
Public.

Description

Add intro to any Chrome app API with no overview docs. This intro has a very brief description of the API usage and a link to any related docs, if available. At the moment, the related docs are in the heading 4. In a separate cl, I will add 'Availabile in' information, and may use a table format for both related doc and available in. This cl also includes broken link fixes to app_hardware.html. Note: this does not include experimental APIs or APIs with existing intros. Additional improvements to be made in separate cls. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170567

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -13 lines) Patch
M chrome/common/extensions/docs/templates/articles/app_hardware.html View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/alarms.html View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/app_runtime.html View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/app_window.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/bluetooth.html View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/fileSystem.html View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/intros/serial.html View 1 2 3 1 chunk +9 lines, -0 lines 1 comment Download
A chrome/common/extensions/docs/templates/intros/usb.html View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/alarms.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_runtime.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_window.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/bluetooth.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/fileSystem.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/serial.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/usb.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/alarms.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
saroop
https://codereview.chromium.org/11412117/diff/1/chrome/common/extensions/docs/templates/articles/app_hardware.html File chrome/common/extensions/docs/templates/articles/app_hardware.html (right): https://codereview.chromium.org/11412117/diff/1/chrome/common/extensions/docs/templates/articles/app_hardware.html#newcode5 chrome/common/extensions/docs/templates/articles/app_hardware.html:5: This doc shows you how packaged apps can connect ...
8 years, 1 month ago (2012-11-20 22:17:30 UTC) #1
mkearney1
Sriram, your chromium email came up this time. https://chromiumcodereview.appspot.com/11412117/diff/1/chrome/common/extensions/docs/templates/articles/app_hardware.html File chrome/common/extensions/docs/templates/articles/app_hardware.html (right): https://chromiumcodereview.appspot.com/11412117/diff/1/chrome/common/extensions/docs/templates/articles/app_hardware.html#newcode5 chrome/common/extensions/docs/templates/articles/app_hardware.html:5: This ...
8 years, 1 month ago (2012-11-20 22:27:11 UTC) #2
miket_OOO
lgtm https://codereview.chromium.org/11412117/diff/5001/chrome/common/extensions/docs/templates/articles/app_hardware.html File chrome/common/extensions/docs/templates/articles/app_hardware.html (right): https://codereview.chromium.org/11412117/diff/5001/chrome/common/extensions/docs/templates/articles/app_hardware.html#newcode13 chrome/common/extensions/docs/templates/articles/app_hardware.html:13: we've included a link to a bluetooth sample ...
8 years ago (2012-11-28 19:21:22 UTC) #3
mkearney1
https://codereview.chromium.org/11412117/diff/5001/chrome/common/extensions/docs/templates/articles/app_hardware.html File chrome/common/extensions/docs/templates/articles/app_hardware.html (right): https://codereview.chromium.org/11412117/diff/5001/chrome/common/extensions/docs/templates/articles/app_hardware.html#newcode13 chrome/common/extensions/docs/templates/articles/app_hardware.html:13: we've included a link to a bluetooth sample below. ...
8 years ago (2012-11-30 21:42:59 UTC) #4
miket_OOO
8 years ago (2012-11-30 21:56:52 UTC) #5
LGTM after fixing one major issue.

https://codereview.chromium.org/11412117/diff/11017/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/intros/serial.html (right):

https://codereview.chromium.org/11412117/diff/11017/chrome/common/extensions/...
chrome/common/extensions/docs/templates/intros/serial.html:3: to read to and
write from a device connected to a serial port.
whoops! "read from and write to"

Powered by Google App Engine
This is Rietveld 408576698