Issue 11412108: Install ContentShell.apk on android perf bot tester.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412108: Install ContentShell.apk on android perf bot tester. (Closed)

Created:
8 years, 1 month ago by tonyg

Modified:
8 years ago

Reviewers:
cmp, Isaac (away)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Isaac (away)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Install ContentShell.apk on android perf bot tester. BUG=None TEST=Manual on linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168877

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	build/android/buildbot/bb_perf_gn_tests.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/android/buildbot/buildbot_functions.sh	View		2 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm And this is an example of a review you should continue to send to ...

8 years, 1 month ago (2012-11-20 19:14:05 UTC) #2

Isaac (away)

This CL is causing duplicate step names on our bots. Can I ask the motivation ...

8 years ago (2012-12-10 07:59:24 UTC) #3

tonyg

8 years ago (2012-12-10 17:34:24 UTC) #4

Message was sent while issue was closed.

On 2012/12/10 07:59:24, Isaac wrote:
> This CL is causing duplicate step names on our bots.  Can I ask the motivation
> for the extra BUILD_STEP (line 327)?  Tracking issue at crbug.com/161993.

Since bb_install_apk outputs a BUILD_STEP called "Install $APK", I didn't think
we'd want the running of instrumentation tests to fall within the install step.
I didn't notice the python script also outputs a BUILD_STEP. It would be nice if
al the build steps output lines were in one place, otherwise it kind of turns
into spaghetti.

Expand Messages | Collapse Messages