Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 11412105: - Move length getter and setter interceptors to the new interceptor scheme. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 15190)
+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)
@@ -68,17 +68,14 @@
visitBasicBlock(HBasicBlock block) {
if (block.isLoopHeader()) {
block.forEachPhi((HPhi phi) {
- HType propagatedType = types[phi];
- // Once the propagation has run once, the propagated type can already
- // be set. In this case we use that one for the first iteration of the
- // loop.
- if (propagatedType.isUnknown()) {
- // Set the initial type for the phi. In theory we would need to mark
- // the type of all other incoming edges as "unitialized" and take this
- // into account when doing the propagation inside the phis. Just
- // setting the propagated type is however easier.
- types[phi] = types[phi.inputs[0]];
- }
+ // Set the initial type for the phi. We're not using the type
+ // the phi thinks it has because new optimizations may imply
+ // changing it.
+ // In theory we would need to mark
+ // the type of all other incoming edges as "unitialized" and take this
+ // into account when doing the propagation inside the phis. Just
+ // setting the propagated type is however easier.
+ types[phi] = types[phi.inputs[0]];
addToWorkList(phi);
});
} else {

Powered by Google App Engine
This is Rietveld 408576698