src/mips/code-stubs-mips.cc - Issue 11412096: Use slot instead of value in the write barrier to record write from code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/code-stubs-mips.cc

Issue 11412096: Use slot instead of value in the write barrier to record write from code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/code-stubs-mips.cc

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc

index f1f921fe8d8bbf63327071db31479d04543c1b7c..41cb094fc9968288d9b07c435c2aea34dbf69204 100644

--- a/src/mips/code-stubs-mips.cc

+++ b/src/mips/code-stubs-mips.cc

@@ -7601,12 +7601,7 @@ void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm, Mode mode) {

ASSERT(!address.is(a0));

__ Move(address, regs_.address());

__ Move(a0, regs_.object());

- if (mode == INCREMENTAL_COMPACTION) {

- __ Move(a1, address);

- } else {

- ASSERT(mode == INCREMENTAL);

- __ lw(a1, MemOperand(address, 0));

- }

+ __ Move(a1, address);

__ li(a2, Operand(ExternalReference::isolate_address()));

AllowExternalCallThatCantCauseGC scope(masm);

« no previous file with comments | « src/incremental-marking.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »