Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 11412096: Use slot instead of value in the write barrier to record write from code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/incremental-marking.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7207 matching lines...) Expand 10 before | Expand all | Expand 10 after
7218 regs_.Restore(masm); 7218 regs_.Restore(masm);
7219 __ ret(0); 7219 __ ret(0);
7220 } 7220 }
7221 7221
7222 7222
7223 void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm, Mode mode) { 7223 void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm, Mode mode) {
7224 regs_.SaveCallerSaveRegisters(masm, save_fp_regs_mode_); 7224 regs_.SaveCallerSaveRegisters(masm, save_fp_regs_mode_);
7225 int argument_count = 3; 7225 int argument_count = 3;
7226 __ PrepareCallCFunction(argument_count, regs_.scratch0()); 7226 __ PrepareCallCFunction(argument_count, regs_.scratch0());
7227 __ mov(Operand(esp, 0 * kPointerSize), regs_.object()); 7227 __ mov(Operand(esp, 0 * kPointerSize), regs_.object());
7228 if (mode == INCREMENTAL_COMPACTION) { 7228 __ mov(Operand(esp, 1 * kPointerSize), regs_.address()); // Slot.
7229 __ mov(Operand(esp, 1 * kPointerSize), regs_.address()); // Slot.
7230 } else {
7231 ASSERT(mode == INCREMENTAL);
7232 __ mov(regs_.scratch0(), Operand(regs_.address(), 0));
7233 __ mov(Operand(esp, 1 * kPointerSize), regs_.scratch0()); // Value.
7234 }
7235 __ mov(Operand(esp, 2 * kPointerSize), 7229 __ mov(Operand(esp, 2 * kPointerSize),
7236 Immediate(ExternalReference::isolate_address())); 7230 Immediate(ExternalReference::isolate_address()));
7237 7231
7238 AllowExternalCallThatCantCauseGC scope(masm); 7232 AllowExternalCallThatCantCauseGC scope(masm);
7239 if (mode == INCREMENTAL_COMPACTION) { 7233 if (mode == INCREMENTAL_COMPACTION) {
7240 __ CallCFunction( 7234 __ CallCFunction(
7241 ExternalReference::incremental_evacuation_record_write_function( 7235 ExternalReference::incremental_evacuation_record_write_function(
7242 masm->isolate()), 7236 masm->isolate()),
7243 argument_count); 7237 argument_count);
7244 } else { 7238 } else {
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
7455 // Restore ecx. 7449 // Restore ecx.
7456 __ pop(ecx); 7450 __ pop(ecx);
7457 __ ret(0); 7451 __ ret(0);
7458 } 7452 }
7459 7453
7460 #undef __ 7454 #undef __
7461 7455
7462 } } // namespace v8::internal 7456 } } // namespace v8::internal
7463 7457
7464 #endif // V8_TARGET_ARCH_IA32 7458 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/incremental-marking.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698