[rlz,cros] RLZ glue for ChromeOS.

chrome/browser/google/google_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_util.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/google/google_url_tracker.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/net/url_util.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 
 #if defined(OS_MACOSX)
 #include "chrome/browser/mac/keystone_glue.h"
+#elif defined(OS_CHROMEOS)
+#include "base/file_util.h"
+#include "base/lazy_instance.h"
+#include "base/string_util.h"
+#include "base/threading/thread_restrictions.h"
 #endif
 
 #if defined(GOOGLE_CHROME_BUILD)
 #include "chrome/browser/google/linkdoctor_internal/linkdoctor_internal.h"
 #endif
 
 #ifndef LINKDOCTOR_SERVER_REQUEST_URL
 #define LINKDOCTOR_SERVER_REQUEST_URL ""
 #endif
 
@@ skipping 12 matching lines @@
        itr != parameters.end();
        ++itr) {
     if (StartsWithASCII(*itr, "q=", false) && itr->size() > 2)
       return true;
   }
   return false;
 }
 
 bool gUseMockLinkDoctorBaseURLForTesting = false;
 
+#if defined(OS_CHROMEOS)

[Peter Kasting, 2012/11/19 20:59:10]

Nit: Maybe this whole block should go in its own .cc/.h file instead so we could
reduce the amount if #ifdefed stuff in cross-platform files.

[Ivan Korotkov, 2012/11/28 14:24:22]

Done.

+// Path to file that stores RLZ brand code on ChromeOS.
+const char kRLZBrandFilePath[] =
+    FILE_PATH_LITERAL("/opt/oem/etc/rlz_brand_code");
+
+// Simple class for caching brand code, meant to be used as a LazyInstance.

[Peter Kasting, 2012/11/19 20:59:10]

Do we really need thread-safety?  I thought the google_util functions were
UI-thread only.

If we don't need thread safety, then LazyInstance isn't needed.  Do something
like this instead:

const std::string& GetBrand() {
  CR_DEFINE_STATIC_LOCAL(std::string, brand, ());
  ...
  file_util::ReadFileToString(brand_file_path, &brand);
  ...
  return brand;
}

This is simpler (the class disappears entirely) and avoids running a destructor
at program exit as well.

+class BrandCode {
+ public:
+  BrandCode() {

[Peter Kasting, 2012/11/19 20:59:10]

Nit: Don't inline non-accessor methods, even for classes declared in a .cc file

+    // Need to perform I/O for the first time, same as on Win.
+    // TODO(ivankr): as discussed, this will be moved to OOBE->EULA stage.

[Peter Kasting, 2012/11/19 20:59:10]

Can this be done now?  I'm leery of adding ScopedAllowIOs unless there is no
other choice.

[Ivan Korotkov, 2012/11/28 14:24:22]

Done.

+    base::ThreadRestrictions::ScopedAllowIO allow_io;
+    FilePath brand_file_path(kRLZBrandFilePath);
+    if (!file_util::ReadFileToString(brand_file_path, &brand_))
+      LOG(WARNING) << "Brand code file missing: " << brand_file_path.value();
+    TrimWhitespace(brand_, TRIM_ALL, &brand_);
+  }
+
+  // Brand code, may be empty.
+  const std::string& brand() { return brand_; }
+
+ private:
+  std::string brand_;
+};

[Peter Kasting, 2012/11/19 20:59:10]

Nit: DISALLOW_COPY_AND_ASSIGN

+
+base::LazyInstance<BrandCode> g_cached_brand = LAZY_INSTANCE_INITIALIZER;
+#endif
+
 }  // anonymous namespace
 
 namespace google_util {
 
 GURL LinkDoctorBaseURL() {
   if (gUseMockLinkDoctorBaseURLForTesting)
     return GURL("http://mock.linkdoctor.url/for?testing");
   return GURL(LINKDOCTOR_SERVER_REQUEST_URL);
 }
 
@@ skipping 65 matching lines @@
 #else
 
 bool GetBrand(std::string* brand) {
   if (brand_for_testing) {
     brand->assign(brand_for_testing);
     return true;
   }
 
 #if defined(OS_MACOSX)
   brand->assign(keystone_glue::BrandCode());
+#elif defined(OS_CHROMEOS)
+  brand->assign(g_cached_brand.Get().brand());
 #else
   brand->clear();
 #endif
   return true;
 }
 
 bool GetReactivationBrand(std::string* brand) {
   brand->clear();
   return true;
 }
@@ skipping 163 matching lines @@
   const char* const kBrands[] = {
     "CHIQ", "CHSG", "HLJY", "NTMO", "OOBA", "OOBB", "OOBC", "OOBD", "OOBE",
     "OOBF", "OOBG", "OOBH", "OOBI", "OOBJ", "IDCM",
   };
   const char* const* end = &kBrands[arraysize(kBrands)];
   const char* const* found = std::find(&kBrands[0], end, brand);
   return found != end;
 }
 
 }  // namespace google_util