src/parser.cc - Issue 11412007: Removed a bunch of GetExistingThreadLocal calls by threading the Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 11412007: Removed a bunch of GetExistingThreadLocal calls by threading the Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed feedback Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 502e1e64eda9aefa1989b78ea3e37f84ae4409b6..16f41c2ab71c9b4aab697b1973ccc0e8a10b3ccc 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -3203,7 +3203,8 @@ Expression* Parser::ParseUnaryExpression(bool* ok) {

if (op == Token::NOT) {

// Convert the literal to a boolean condition and negate it.

bool condition = literal->ToBoolean()->IsTrue();

- Handle<Object> result(isolate()->heap()->ToBoolean(!condition));

+ Handle<Object> result(isolate()->heap()->ToBoolean(!condition),

+ isolate());

return factory()->NewLiteral(result);

} else if (literal->IsNumber()) {

// Compute some expressions involving only number literals.

« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »