Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1141173003: Update the set of known roots for Windows and Mac (Closed)

Created:
5 years, 7 months ago by Ryan Sleevi
Modified:
5 years, 7 months ago
Reviewers:
eroman, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the set of known roots for Windows and Mac Update the set of known roots for Windows and Mac. This affects the |is_issued_by_known_roots| check on these platforms, which controls things such as the enforcement of Baseline Requirements. BUG=481573 R=davidben@chromium.org Committed: https://crrev.com/09d369562f5c73aa66cebc0809f55291899ab20a Cr-Commit-Position: refs/heads/master@{#330868}

Patch Set 1 #

Patch Set 2 : Fix ordering #

Patch Set 3 : Add roots from 10.10.3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -6 lines) Patch
M net/cert/x509_certificate_known_roots_mac.h View 1 2 24 chunks +130 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_known_roots_win.h View 1 38 chunks +119 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Ryan Sleevi
David: For your... enjoyment. I'll follow-up with you offline the challenges in verifying this, and ...
5 years, 7 months ago (2015-05-16 01:10:01 UTC) #1
Ryan Sleevi
Oh, I should add, the main thing to review is to make sure I didn't ...
5 years, 7 months ago (2015-05-16 01:10:16 UTC) #2
Ryan Sleevi
Fixed the few obvious ordering issues. Welcome to hell :)
5 years, 7 months ago (2015-05-16 01:18:53 UTC) #3
davidben
Verified that the ordering is right. We probably could just have a unit test which ...
5 years, 7 months ago (2015-05-18 17:56:36 UTC) #4
Ryan Sleevi
On 2015/05/18 17:56:36, David Benjamin wrote: > Did you want me to check the hashes? ...
5 years, 7 months ago (2015-05-18 23:36:40 UTC) #5
davidben
rubber stamp lgtm
5 years, 7 months ago (2015-05-19 18:14:28 UTC) #6
Ryan Sleevi
david: post review to add the roots for 10.10.3 if you can peep (also listed ...
5 years, 7 months ago (2015-05-21 00:11:11 UTC) #7
Ryan Sleevi
Actually, poking eroman for the inter-diff for a better timezone :)
5 years, 7 months ago (2015-05-21 00:11:52 UTC) #9
eroman
rubberstamp LGTM
5 years, 7 months ago (2015-05-21 00:16:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141173003/40001
5 years, 7 months ago (2015-05-21 00:19:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 01:31:04 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 01:32:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09d369562f5c73aa66cebc0809f55291899ab20a
Cr-Commit-Position: refs/heads/master@{#330868}

Powered by Google App Engine
This is Rietveld 408576698