Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1141163004: Bug: Runtime_GrowArrayElements provoked unnecessary lazy deopt. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bug: Runtime_GrowArrayElements provoked unnecessary lazy deopt. Unnecessary, and unhandled as well. BUG=488398 R=jarin@chromium.org LOG=N Committed: https://crrev.com/de3a1ca02eb0f3c89ddaefbac98e0c4fce3e606c Cr-Commit-Position: refs/heads/master@{#28421}

Patch Set 1 #

Patch Set 2 : Added test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/runtime/runtime-array.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-488398.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Jaroslav, thanks for the help with this one! --Michael
5 years, 7 months ago (2015-05-15 12:36:00 UTC) #1
Jarin
lgtm
5 years, 7 months ago (2015-05-15 12:38:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141163004/20001
5 years, 7 months ago (2015-05-15 13:00:14 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 13:05:13 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 13:05:26 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de3a1ca02eb0f3c89ddaefbac98e0c4fce3e606c
Cr-Commit-Position: refs/heads/master@{#28421}

Powered by Google App Engine
This is Rietveld 408576698