Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1141163003: Enabled first-run tutorial for ephemeral users. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled first-run tutorial for ephemeral users. First-run tutorial is shown for regular ephemeral users, but only if we 100% sure that this user has never seen the tutorial yet. BUG=333264 TEST=manually Committed: https://crrev.com/b2af9e744c80506436d2b7f8f6a4427e5c963d33 Cr-Commit-Position: refs/heads/master@{#330186}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/browser/chromeos/first_run/first_run.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 15 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141163003/1
5 years, 7 months ago (2015-05-15 08:27:39 UTC) #2
dzhioev (left Google)
Nikita, PTAL
5 years, 7 months ago (2015-05-15 08:27:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 08:52:49 UTC) #6
Nikita (slow)
https://codereview.chromium.org/1141163003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/1141163003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode408 chrome/browser/chromeos/login/wizard_controller.cc:408: user_manager->GetLoggedInUser()->GetType() != What about ephemeral regular users? I think ...
5 years, 7 months ago (2015-05-15 14:05:04 UTC) #7
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-15 14:05:09 UTC) #8
dzhioev (left Google)
https://codereview.chromium.org/1141163003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/1141163003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode408 chrome/browser/chromeos/login/wizard_controller.cc:408: user_manager->GetLoggedInUser()->GetType() != On 2015/05/15 14:05:03, Nikita wrote: > What ...
5 years, 7 months ago (2015-05-15 20:09:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141163003/1
5 years, 7 months ago (2015-05-15 20:11:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 20:23:49 UTC) #12
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 1 (id:??) landed as https://crrev.com/b2af9e744c80506436d2b7f8f6a4427e5c963d33 Cr-Commit-Position: refs/heads/master@{#330186}
5 years, 7 months ago (2015-05-16 05:29:54 UTC) #13
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 1 (id:??) landed as https://crrev.com/b2af9e744c80506436d2b7f8f6a4427e5c963d33 Cr-Commit-Position: refs/heads/master@{#330186}
5 years, 7 months ago (2015-05-16 05:30:48 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:26:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2af9e744c80506436d2b7f8f6a4427e5c963d33
Cr-Commit-Position: refs/heads/master@{#330186}

Powered by Google App Engine
This is Rietveld 408576698