Browser tests for the new way of handling device ID in Chrome OS.

chrome/browser/chromeos/login/test/oobe_base_test.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_TEST_OOBE_BASE_TEST_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_TEST_OOBE_BASE_TEST_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "chrome/browser/chromeos/login/test/https_forwarder.h"
+#include "chrome/browser/chromeos/login/test/js_checker.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "content/public/test/test_utils.h"
 #include "google_apis/gaia/fake_gaia.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 namespace content {
 class WebUI;
@@ skipping 43 matching lines @@
   void SimulateNetworkOnline();
   void SimulateNetworkPortal();
 
   base::Closure SimulateNetworkOfflineClosure();
   base::Closure SimulateNetworkOnlineClosure();
   base::Closure SimulateNetworkPortalClosure();
 
   // Checks JavaScript |expression| in login screen.
   void JsExpect(const std::string& expression);
 
+  test::JSChecker& JS() { return js_checker_; }

[achuithb, 2015/05/26 06:28:21]

I think returning a pointer is preferred to a non-const reference here.

[dzhioev (left Google), 2015/05/26 21:18:15]

Why? I don't see any advantage in that.

[achuithb, 2015/05/26 21:26:44]

This is for arguments, but I think the logic also holds for return values:
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Reference_Ar...

If you have strong feelings about this, I'm fine with returning non-const
reference. I'm sure there are plenty of places in the codebase that do exactly
this.
 

+
   bool use_webview() { return use_webview_; }
   void set_use_webview(bool use_webview) { use_webview_ = use_webview; }
 
   bool initialize_fake_merge_session() {
     return initialize_fake_merge_session_;
   }
   void set_initialize_fake_merge_session(bool value) {
     initialize_fake_merge_session_ = value;
   }
 
@@ skipping 15 matching lines @@
   // Whether to use background networking. Note this is only effective when it
   // is set before SetUpCommandLine is invoked.
   bool needs_background_networking_;
 
   scoped_ptr<content::WindowedNotificationObserver> login_screen_load_observer_;
   scoped_ptr<extensions::ScopedCurrentChannel> scoped_channel_;
   HTTPSForwarder gaia_https_forwarder_;
   std::string gaia_frame_parent_;
   bool use_webview_;
   bool initialize_fake_merge_session_;
+  test::JSChecker js_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(OobeBaseTest);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_TEST_OOBE_BASE_TEST_H_