Issue 1141143002: Roll PDFium to f33cdd5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1141143002: Roll PDFium to f33cdd5 (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll PDFium to f33cdd5 f33cdd5 Make CFX_StringData be scoped 8b2d91c Fix integer overflow in conversion from float to integer. 1b8a296 Use phantom handles instead of weak handles 8aa1eac Tidy public/ directory. fdc5e69 Fix comparison of CFX_ByteString and CFX_WideString against empty literals. 2a47d8d Set pointers in internal fields directly instead of wrapping them b2aa543 Make (and verify) public/ files compile under C. e6bd866 Describe required properties of public/ files with a README. feb10c5 Restore checked strlen conversions. R=tsepez@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

On 2015/05/15 00:03:39, jochen (traveling) wrote: Looks like I broke something ... in 8aa1eac

5 years, 7 months ago (2015-05-15 00:16:11 UTC) #2

Tom Sepez

On 2015/05/15 00:16:11, Tom Sepez wrote: > On 2015/05/15 00:03:39, jochen (traveling) wrote: > > ...

5 years, 7 months ago (2015-05-15 00:24:47 UTC) #3

Tom Sepez

5 years, 7 months ago (2015-05-15 00:52:43 UTC) #4

On 2015/05/15 00:24:47, Tom Sepez wrote:
> On 2015/05/15 00:16:11, Tom Sepez wrote:
> > On 2015/05/15 00:03:39, jochen (traveling) wrote:
> > 
> > Looks like I broke something ... in 8aa1eac
> And we need corresponding changes in chrome.  I'll take care of this one, then
> ... Sorry.

See https://codereview.chromium.org/1132293005/

Expand Messages | Collapse Messages