Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 11411362: Add aura-related tests to the gatekeeper on Linux and Windows (Closed)

Created:
8 years ago by Paweł Hajdan Jr.
Modified:
8 years ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Add aura-related tests to the gatekeeper on Linux and Windows (that makes the gatekeeper close the tree when they fail). BUG=163905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171115

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/masters/master.chromium.linux/master_gatekeeper_cfg.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M build/masters/master.chromium.win/master_gatekeeper_cfg.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Paweł Hajdan Jr.
Please review: M-A: entire CL John: FYI Would this require a master restart?
8 years ago (2012-12-04 18:30:53 UTC) #1
M-A Ruel
yes it requires a master restart. https://codereview.chromium.org/11411362/diff/1/build/masters/master.chromium.linux/master_gatekeeper_cfg.py File build/masters/master.chromium.linux/master_gatekeeper_cfg.py (right): https://codereview.chromium.org/11411362/diff/1/build/masters/master.chromium.linux/master_gatekeeper_cfg.py#newcode16 build/masters/master.chromium.linux/master_gatekeeper_cfg.py:16: 'ash_unittests', I don't ...
8 years ago (2012-12-04 18:36:43 UTC) #2
jam
thanks. what about lkgr, i think you'll need something like https://codereview.chromium.org/11418274/diff/1/masters/master.chromium.lkgr/lkgr_finder.py?
8 years ago (2012-12-04 18:39:40 UTC) #3
cmp
On 2012/12/04 18:39:40, John Abd-El-Malek wrote: > what about lkgr, i think you'll need something ...
8 years ago (2012-12-04 19:47:02 UTC) #4
Paweł Hajdan Jr.
PTAL
8 years ago (2012-12-04 22:07:06 UTC) #5
cmp
Can you add ash_unittests to the appropriate tester on chromium.linux?
8 years ago (2012-12-04 23:42:39 UTC) #6
cmp
Nevermind, I think I understand that ash_unittests isn't in John's LKGR change and isn't running ...
8 years ago (2012-12-04 23:43:53 UTC) #7
jam
8 years ago (2012-12-06 20:21:21 UTC) #8
looks like Nicholas just restarted the Linux master. When is the next
planned Windows master restart?

On Tue, Dec 4, 2012 at 3:43 PM, <cmp@chromium.org> wrote:

> Nevermind, I think I understand that ash_unittests isn't in John's LKGR
> change
> and isn't running on chromium.linux because it shouldn't run there.
>
> lgtm in that case
>
>
https://codereview.chromium.**org/11411362/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698