Issue 11411361: Enable skia's separable mask blur. Remove the SK_DISABLE_SEPARABLE_MASK_BLUR flag from skia.gyp, a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411361: Enable skia's separable mask blur. Remove the SK_DISABLE_SEPARABLE_MASK_BLUR flag from skia.gyp, a… (Closed)

Created:
8 years ago by Stephen White

Modified:
8 years ago

Reviewers:
robertphillips

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable skia's separable mask blur. Remove the SK_DISABLE_SEPARABLE_MASK_BLUR flag from skia.gyp, and suppress the resulting failures until they are rebaselined. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171008

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
	M	skia/skia.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	skia/skia_test_expectations.txt	View		1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

8 years ago (2012-12-04 18:26:08 UTC) #3

On 2012/12/04 17:17:34, Stephen White wrote:
> PTAL

Note:  I'll add fillText-shadow (both flavours) to the suppressions for the Mac
on landing.

effect-reference-* are unrelated (crashing on the waterfall as well; Dana is
fixing in https://codereview.chromium.org/11308354/)

newly-composited-on-scroll.html (also fails without the patch).

Expand Messages | Collapse Messages