Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11411356: Reduce debug printing from test script when testing --build-directory option. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed debugging code. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index d99ba3b87e42dbad34946fb593e88ad3954082a6..ee4023a610ec1cfd334cbebad66500bfe6b47c5c 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1516,17 +1516,16 @@ class TestUtils {
"Expected ${dir} to already exist");
var segments = relativePath.segments();
for (String segment in segments) {
- // Ugly hack: if Windows absolute path starts with a drive,
- // rewrite [base] properly.
- if (segment.length == 2 && segment.endsWith(':')) {
- base = new Path(segment);
+ base = base.append(segment);
+ if (base.toString() == "/$segment" &&
Anton Muhin 2012/12/04 14:19:57 this all looks ugly, maybe we should extend Path a
+ segment.length == 2 &&
+ segment.endsWith(':')) {
+ // Skip the directory creation for a path like "/E:".
continue;
}
- base = base.append(segment);
dir = new Directory.fromPath(base);
- print("======= creating $dir $base");
if (!dir.existsSync()) {
- dir.createSync();
+ dir.createSync();
}
Expect.isTrue(dir.existsSync(), "Failed to create ${dir.path}");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698