Issue 11411352: Clear syncing flag after a remote or local sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411352: Clear syncing flag after a remote or local sync (Closed)

Created:
8 years ago by kinuko

Modified:
8 years ago

Reviewers:
tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, nhiroki

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear syncing flag after a remote or local sync - Stop clearing sync flag locally in ProcessLocalChange for local sync - *Always* clear sync flag after a local or remote sync BUG=155505 TEST=LocalFileSyncServiceTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170948

Patch Set 1 #

Patch Set 2 : also check REMOTE_SERVICE_DISABLED state #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -27 lines)			Patch
M	chrome/browser/sync_file_system/local_file_sync_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/local_file_sync_service.cc	View		3 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/sync_file_system/local_file_sync_service_unittest.cc	View		7 chunks	+5 lines, -15 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service.cc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	webkit/fileapi/syncable/local_file_sync_context.h	View		2 chunks	+11 lines, -5 lines	0 comments	Download
M	webkit/fileapi/syncable/local_file_sync_context.cc	View		2 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

Updated DidProcessRemoteChange to also check if the remote state is DISABLED or not. PTAL thanks,

8 years ago (2012-12-04 09:30:56 UTC) #2

lgtm

Expand Messages | Collapse Messages