Extract the code for supporing extended desktop from WorkspaceWindowResizer into DragWindowResizer.

Extract the code for supporing extended desktop from WorkspaceWindowResizer into DragWindowResizer.

DragWindowResizer decorates another WindowResizer and adds the ability to
move a window across displays.

This CL depends on
https://codereview.chromium.org/11280283/.

BUG=156519
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171624

[mazda, 2012-12-04 01:52:19]

This is another refactoring necessary to enable modal windows to move across
displays.

[sky, 2012-12-04 15:58:53]

https://codereview.chromium.org/11411344/diff/3001/ash/wm/default_window_resi...
File ash/wm/default_window_resizer.h (right):

https://codereview.chromium.org/11411344/diff/3001/ash/wm/default_window_resi...
ash/wm/default_window_resizer.h:18: explicit DefaultWindowResizer(const Details&
details);
Move constructor in .cc to match position.

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:24: struct Details {
Why do you need to expose all this?

[mazda, 2012-12-04 18:44:41]

https://codereview.chromium.org/11411344/diff/3001/ash/wm/default_window_resi...
File ash/wm/default_window_resizer.h (right):

https://codereview.chromium.org/11411344/diff/3001/ash/wm/default_window_resi...
ash/wm/default_window_resizer.h:18: explicit DefaultWindowResizer(const Details&
details);
On 2012/12/04 15:58:53, sky wrote:
> Move constructor in .cc to match position.

Done.

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:24: struct Details {
On 2012/12/04 15:58:53, sky wrote:
> Why do you need to expose all this?

I needed to create Details in CreateWindowResizer (declared at the end of this
file) to pass it to DragWindowResizer's constructor.
Is it better to add DragWindowResizer::Create and create Details in it to keep
Details protected?

[sky, 2012-12-04 22:39:43]

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h#ne...
ash/wm/window_resizer.h:24: struct Details {
On 2012/12/04 18:44:41, mazda wrote:
> On 2012/12/04 15:58:53, sky wrote:
> > Why do you need to expose all this?
> 
> I needed to create Details in CreateWindowResizer (declared at the end of this
> file) to pass it to DragWindowResizer's constructor.
> Is it better to add DragWindowResizer::Create and create Details in it to keep
> Details protected?

Yes please.

[mazda, 2012-12-04 23:31:19]

On 2012/12/04 22:39:43, sky wrote:
> https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h
> File ash/wm/window_resizer.h (right):
> 
>
https://codereview.chromium.org/11411344/diff/3001/ash/wm/window_resizer.h#ne...
> ash/wm/window_resizer.h:24: struct Details {
> On 2012/12/04 18:44:41, mazda wrote:
> > On 2012/12/04 15:58:53, sky wrote:
> > > Why do you need to expose all this?
> > 
> > I needed to create Details in CreateWindowResizer (declared at the end of
this
> > file) to pass it to DragWindowResizer's constructor.
> > Is it better to add DragWindowResizer::Create and create Details in it to
keep
> > Details protected?
> 
> Yes please.

I restored Details to protected.
Please take another look.

[sky, 2012-12-05 00:48:08]

LGTM

[commit-bot: I haz the power, 2012-12-06 20:11:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/11411344/26001

[commit-bot: I haz the power, 2012-12-06 23:03:44]

Change committed as 171624