Fix for issue 7089 (Symbols::New was not quite working correctly

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 10033 matching lines @@
 
 
 RawInstance* String::Canonicalize() const {
   if (IsCanonical()) {
     return this->raw();
   }
   return Symbols::New(*this);
 }
 
 
-RawString* String::New(const char* str, Heap::Space space) {
-  ASSERT(str != NULL);
-  intptr_t array_len = strlen(str);
-  const uint8_t* utf8_array = reinterpret_cast<const uint8_t*>(str);
-  return String::New(utf8_array, array_len, space);
+RawString* String::New(const char* cstr, Heap::Space space) {
+  ASSERT(cstr != NULL);
+  intptr_t array_len = strlen(cstr);
+  const uint8_t* utf8_array = reinterpret_cast<const uint8_t*>(cstr);
+  return String::FromUTF8(utf8_array, array_len, space);
 }
 
 
-RawString* String::New(const uint8_t* utf8_array,
-                       intptr_t array_len,
-                       Heap::Space space) {
+RawString* String::FromUTF8(const uint8_t* utf8_array,
+                            intptr_t array_len,
+                            Heap::Space space) {
   Utf8::Type type;
   intptr_t len = Utf8::CodeUnitCount(utf8_array, array_len, &type);
   if (type == Utf8::kLatin1) {
     const String& strobj = String::Handle(OneByteString::New(len, space));
     if (len > 0) {
       NoGCScope no_gc;
       Utf8::DecodeToLatin1(utf8_array, array_len,
                            OneByteString::CharAddr(strobj, 0), len);
     }
     return strobj.raw();
   }
   ASSERT((type == Utf8::kBMP) || (type == Utf8::kSupplementary));
   const String& strobj = String::Handle(TwoByteString::New(len, space));
   NoGCScope no_gc;
   Utf8::DecodeToUTF16(utf8_array, array_len,
                       TwoByteString::CharAddr(strobj, 0), len);
   return strobj.raw();
 }
 
 
+RawString* String::New(const uint8_t* latin1_array,
+                       intptr_t array_len,
+                       Heap::Space space) {
+  return OneByteString::New(latin1_array, array_len, space);
+}
+
+
 RawString* String::New(const uint16_t* utf16_array,
                        intptr_t array_len,
                        Heap::Space space) {
   bool is_one_byte_string = true;
   for (intptr_t i = 0; i < array_len; ++i) {
     if (!Utf::IsLatin1(utf16_array[i])) {
       is_one_byte_string = false;
       break;
     }
   }
@@ skipping 1988 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart