Fix for issue 7089 (Symbols::New was not quite working correctly

vm/double_conversion.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/double_conversion.h"
 
 #include "third_party/double-conversion/src/double-conversion.h"
 
 #include "vm/exceptions.h"
 #include "vm/globals.h"
@@ skipping 73 matching lines @@
       kDoubleToStringCommonInfinitySymbol,
       kDoubleToStringCommonNaNSymbol,
       kDoubleToStringCommonExponentChar,
       0, 0, 0, 0);  // Last four values are ignored in fixed mode.
 
   char* buffer = Isolate::Current()->current_zone()->Alloc<char>(kBufferSize);
   buffer[kBufferSize - 1] = '\0';
   double_conversion::StringBuilder builder(buffer, kBufferSize);
   bool status = converter.ToFixed(d, fraction_digits, &builder);
   ASSERT(status);
-  int length = builder.position();
-  return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+  return String::New(builder.Finalize());
 }
 
 
 RawString* DoubleToStringAsExponential(double d, int fraction_digits) {
   static const int kMinFractionDigits = -1;  // -1 represents shortest mode.
   static const int kMaxFractionDigits = 20;
   static const int kConversionFlags =
       double_conversion::DoubleToStringConverter::EMIT_POSITIVE_EXPONENT_SIGN;
   const int kBufferSize = 128;
 
@@ skipping 12 matching lines @@
       kDoubleToStringCommonInfinitySymbol,
       kDoubleToStringCommonNaNSymbol,
       kDoubleToStringCommonExponentChar,
       0, 0, 0, 0);  // Last four values are ignored in exponential mode.
 
   char* buffer = Isolate::Current()->current_zone()->Alloc<char>(kBufferSize);
   buffer[kBufferSize - 1] = '\0';
   double_conversion::StringBuilder builder(buffer, kBufferSize);
   bool status = converter.ToExponential(d, fraction_digits, &builder);
   ASSERT(status);
-  int length = builder.position();
-  return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+  return String::New(builder.Finalize());
 }
 
 
 RawString* DoubleToStringAsPrecision(double d, int precision) {
   static const int kMinPrecisionDigits = 1;
   static const int kMaxPrecisionDigits = 21;
   static const int kMaxLeadingPaddingZeroes = 6;
   static const int kMaxTrailingPaddingZeroes = 0;
   static const int kConversionFlags =
       double_conversion::DoubleToStringConverter::EMIT_POSITIVE_EXPONENT_SIGN;
@@ skipping 18 matching lines @@
       kDoubleToStringCommonExponentChar,
       0, 0,  // Ignored in precision mode.
       kMaxLeadingPaddingZeroes,
       kMaxTrailingPaddingZeroes);
 
   char* buffer = Isolate::Current()->current_zone()->Alloc<char>(kBufferSize);
   buffer[kBufferSize - 1] = '\0';
   double_conversion::StringBuilder builder(buffer, kBufferSize);
   bool status = converter.ToPrecision(d, precision, &builder);
   ASSERT(status);
-  int length = builder.position();
-  return String::New(reinterpret_cast<uint8_t*>(builder.Finalize()), length);
+  return String::New(builder.Finalize());
 }
 
 }  // namespace dart