Fix for issue 7089 (Symbols::New was not quite working correctly

vm/symbols.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_SYMBOLS_H_
 #define VM_SYMBOLS_H_
 
 #include "vm/object.h"
 #include "vm/snapshot_ids.h"
 
@@ skipping 159 matching lines @@
 
   // Initialize frequently used symbols in the vm isolate.
   static void InitOnce(Isolate* isolate);
 
   // Initialize and setup a symbol table for the isolate.
   static void SetupSymbolTable(Isolate* isolate);
 
   // Get number of symbols in an isolate's symbol table.
   static intptr_t Size(Isolate* isolate);
 
-  // Helper functions to create a symbol given a string or set of characters.
-  static RawString* New(const char* str);
-  template<typename T>
-  static RawString* New(const T* characters, intptr_t len);
+  // Creates a Symbol given a C string that is assumed to contain
+  // UTF-8 encoded characters and '\0' is considered a termination character.

[cshapiro, 2012/12/04 01:00:46]

Same TODO here as well?

[siva, 2012/12/04 02:36:16]

Done.

+  static RawString* New(const char* cstr);
+
+  // Creates a new Symbol from an array of UTF-8 encoded characters.
+  static RawString* NewFromUTF8(const uint8_t* utf8_array, intptr_t len);

[cshapiro, 2012/12/04 01:00:46]

Maybe s/NewFromUTF8/FromUTF8/

?

[siva, 2012/12/04 02:36:16]

Renamed this to FromUTF8 and all the subsequent
ones to FromLatin1, FromUTF16 and FromUTF32 to make
it more explicit.

The motivation of moving the template function as a private
function was to make the API more explicit.

On 2012/12/04 01:00:46, cshapiro wrote:
Done.

+
+  // Creates a new Symbol from an array of Latin-1 encoded characters.
+  static RawString* New(const uint8_t* latin1_array, intptr_t len);
+
+  // Creates a new Symbol from an array of UTF-16 encoded characters.
+  static RawString* New(const uint16_t* utf16_array, intptr_t len);
+
+  // Creates a new Symbol from an array of UTF-32 encoded characters.
+  static RawString* New(const int32_t* utf32_array, intptr_t len);
+
   static RawString* New(const String& str);
   static RawString* New(const String& str,
                         intptr_t begin_index,
                         intptr_t length);
 
   // Returns char* of predefined symbol.
   static const char* Name(SymbolId symbol);
 
   static RawString* FromCharCode(int32_t char_code);
 
   static RawString** PredefinedAddress() {
     return reinterpret_cast<RawString**>(&predefined_);
   }
 
  private:
   enum {
     kInitialVMIsolateSymtabSize = ((kMaxId + 15) & -16),
     kInitialSymtabSize = 256
   };
 
+  // Helper functions to create a symbol given a string or set of characters.
+  template<typename T>
+  static RawString* NewSymbol(const T* characters, intptr_t len);
+
   // Add the string into the VM isolate symbol table.
   static void Add(const Array& symbol_table, const String& str);
 
   // Insert symbol into symbol table, growing it if necessary.
   static void InsertIntoSymbolTable(const Array& symbol_table,
                                     const String& symbol,
                                     intptr_t index);
 
   // Grow the symbol table.
   static void GrowSymbolTable(const Array& symbol_table);
@@ skipping 23 matching lines @@
   friend class SnapshotReader;
   friend class SnapshotWriter;
   friend class ApiMessageReader;
 
   DISALLOW_COPY_AND_ASSIGN(Symbols);
 };
 
 }  // namespace dart
 
 #endif  // VM_SYMBOLS_H_