Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11411332: Replace trampolining in FFmpegDemuxer with explicit thread calling convention checks. (Closed)

Created:
8 years ago by scherkus (not reviewing)
Modified:
8 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Replace trampolining in FFmpegDemuxer with explicit thread calling convention checks. Replaced FFmpegDemuxerStream::read_queue_ with the simpler FFmpegDemuxerStream::read_cb_ since we don't intend to support overlapping reads. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171943

Patch Set 1 #

Total comments: 2

Patch Set 2 : wrapcb #

Patch Set 3 : remove queue #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 3

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -137 lines) Patch
M media/base/bind_to_loop.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M media/base/bind_to_loop.h.pump View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 2 4 chunks +9 lines, -18 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 4 5 6 13 chunks +86 lines, -117 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
While we're busy sorting out the VideoRendererBase side of things, here's a CL for removing ...
8 years ago (2012-12-03 21:47:56 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM https://codereview.chromium.org/11411332/diff/1/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/11411332/diff/1/media/filters/ffmpeg_demuxer.cc#newcode166 media/filters/ffmpeg_demuxer.cc:166: read_queue_.push_back(wrapped_read_cb); Do we still need this queue?
8 years ago (2012-12-03 23:14:21 UTC) #2
scherkus (not reviewing)
PTAL -- removed the queue + rebased + all that jazz https://codereview.chromium.org/11411332/diff/1/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): ...
8 years ago (2012-12-07 22:18:55 UTC) #3
acolwell GONE FROM CHROMIUM
LGTM https://codereview.chromium.org/11411332/diff/16001/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/11411332/diff/16001/media/filters/ffmpeg_demuxer.cc#newcode251 media/filters/ffmpeg_demuxer.cc:251: data_source_->Stop(BindToLoop(message_loop_, base::Bind( nit: BindToCurrentLoop saves a few chars.
8 years ago (2012-12-07 22:59:11 UTC) #4
scherkus (not reviewing)
https://codereview.chromium.org/11411332/diff/16001/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/11411332/diff/16001/media/filters/ffmpeg_demuxer.cc#newcode251 media/filters/ffmpeg_demuxer.cc:251: data_source_->Stop(BindToLoop(message_loop_, base::Bind( On 2012/12/07 22:59:11, acolwell wrote: > nit: ...
8 years ago (2012-12-08 00:00:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11411332/12006
8 years ago (2012-12-08 02:46:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests
8 years ago (2012-12-08 03:38:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/11411332/12006
8 years ago (2012-12-08 03:41:43 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-08 05:51:17 UTC) #9
Message was sent while issue was closed. 
Change committed as 171943

Powered by Google App Engine
This is Rietveld 408576698