Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1141133003: [Autofill] Control using Variations the sending of Autofill field metadata (Closed)

Created:
5 years, 7 months ago by Mathieu
Modified:
5 years, 7 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Control using Variations the sending of Autofill field metadata We default most tests to having the trial enabled because that is the expected way forward. Nevertheless we put the trial so we can control rollout or kill it after the fact. BUG=488602 TBR=asvitkine TEST=FormStructureTest*,AutofillServerTest* Committed: https://crrev.com/fef3d83eac2958b2e65297da7cccd384757deb6b Cr-Commit-Position: refs/heads/master@{#330601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -56 lines) Patch
M chrome/browser/autofill/autofill_server_browsertest.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 4 chunks +22 lines, -10 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 46 chunks +176 lines, -46 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Mathieu
Hi Evan, please have a look. Would like to have this in M44, but can ...
5 years, 7 months ago (2015-05-15 19:27:03 UTC) #2
Mathieu
Friendly ping.
5 years, 7 months ago (2015-05-19 15:34:12 UTC) #3
Evan Stade
sorry for slowness -- lgtm
5 years, 7 months ago (2015-05-19 16:15:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141133003/1
5 years, 7 months ago (2015-05-19 18:04:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64652)
5 years, 7 months ago (2015-05-19 18:11:59 UTC) #8
Mathieu
Hi Alexei, I need your approval for adding variations as a DEPS... Thanks
5 years, 7 months ago (2015-05-19 18:16:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141133003/1
5 years, 7 months ago (2015-05-19 20:15:27 UTC) #12
Mathieu
TBR asvitkine@ since the DEPS approval requirement is a bit silly
5 years, 7 months ago (2015-05-19 20:15:45 UTC) #13
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-19 20:18:51 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 20:50:56 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:51:49 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef3d83eac2958b2e65297da7cccd384757deb6b
Cr-Commit-Position: refs/heads/master@{#330601}

Powered by Google App Engine
This is Rietveld 408576698