lib/src/codegen/js_module_item_order.dart - Issue 1141133002: isLoaded can now handle elements from other libraries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_module_item_order.dart

Issue 1141133002: isLoaded can now handle elements from other libraries (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_module_item_order.dart

diff --git a/lib/src/codegen/js_module_item_order.dart b/lib/src/codegen/js_module_item_order.dart

index eadf6716f5578d1803c6d9a92bf87b085bf49435..072e170d1d76f7f102b33be933af148fa0abdbe4 100644

--- a/lib/src/codegen/js_module_item_order.dart

+++ b/lib/src/codegen/js_module_item_order.dart

@@ -46,7 +46,9 @@ class ModuleItemLoadOrder {

ModuleItemLoadOrder(this._emitModuleItem);

- bool isLoaded(Element e) => _loaded[e] == true;

+ bool isLoaded(Element e) => (e.library == _currentLibrary)

+ ? _loaded[e] == true

+ : libraryIsLoaded(e.library);

/// Collect top-level elements and nodes we need to emit.

void collectElements(

« no previous file with comments | « no previous file | no next file » | no next file with comments »