Issue 11411330: Have ExtensionService notify ThemeService directly for themes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411330: Have ExtensionService notify ThemeService directly for themes (Closed)

Created:
8 years ago by akalin

Modified:
8 years ago

Reviewers:
Elliot Glaysher, pkotwicz, asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Have ExtensionService notify ThemeService directly for themes This is a retry of r169875, hopefully with fewer regressions. This time, I simply notify the theme service (instantiating it if necessary) when a theme extension is installed. This should avoid the theme regression since that path is not taken on browser startup. BUG=161203 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170880

Patch Set 1 #

Patch Set 2 : rebase on head #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -30 lines)			Patch
M	chrome/browser/extensions/extension_service.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/themes/theme_service.h	View	5 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/themes/theme_service.cc	View	3 chunks	+6 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2012/12/03 22:37:52, Antony Sargent wrote: > extensions LGTM TBRing pkotwicz since the theme changes ...

8 years ago (2012-12-04 00:17:59 UTC) #4

commit-bot: I haz the power

8 years ago (2012-12-04 00:19:54 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/11411330/5001

Expand Messages | Collapse Messages