Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: pkg/http/lib/src/utils.dart

Issue 11411327: No longer work around issue 7013 and 7014 in pkg/http. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/http/lib/src/io_client.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http/lib/src/utils.dart
diff --git a/pkg/http/lib/src/utils.dart b/pkg/http/lib/src/utils.dart
index 5bc9b5f43163e7297f5cf1723d57020e7b138d51..1a9aff347e16a94d3542de2a4e593235921b2103 100644
--- a/pkg/http/lib/src/utils.dart
+++ b/pkg/http/lib/src/utils.dart
@@ -144,19 +144,6 @@ Future<List<int>> consumeInputStream(InputStream stream) {
return completer.future;
}
-// TODO(nweiz): this wouldn't be necessary were it not for issue 7013.
-/// Wrap an InputStream in a ListInputStream. This ensures that if the input
-/// stream has invalid onClosed/onError behavior (see issue 7013), that behavior
-/// is papered over.
-InputStream wrapInputStream(InputStream source) {
- var sink = new ListInputStream();
- // TODO(nweiz): Due to issuee 3657, pipeInputToInput naturally avoids calling
- // both onClosed and onError. If 3657 gets fixed before 7013, we'll need to do
- // that explicitly.
- pipeInputToInput(source, sink);
- return sink;
-}
-
/// Takes all input from [source] and writes it to [sink], then closes [sink].
/// Returns a [Future] that completes when [source] is exhausted.
void pipeInputToInput(InputStream source, ListInputStream sink) {
« no previous file with comments | « pkg/http/lib/src/io_client.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698