Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11411321: Merge 135178 (Closed)

Created:
8 years ago by tony
Modified:
8 years ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135178 > [Chromium] Flash cannot receive scroll events when threaded compositing is in use > https://bugs.webkit.org/show_bug.cgi?id=101423 > > Patch by Yusuke Sato <yusukes@chromium.org>; on 2012-11-19 > Reviewed by James Robinson. > > Source/WebKit/chromium: > > Add setWantsWheelEvents() to Chromium's WebPluginContainer interface so that a plugin can tell the > container that the plugin always wants to handle wheel events even when a scroll bar is not shown. > > * public/WebPluginContainer.h: > (WebPluginContainer): > * src/WebPluginContainerImpl.cpp: > (WebKit::WebPluginContainerImpl::setWantsWheelEvents): > (WebKit): > (WebKit::WebPluginContainerImpl::wantsWheelEvents): > (WebKit::WebPluginContainerImpl::WebPluginContainerImpl): > * src/WebPluginContainerImpl.h: > (WebPluginContainerImpl): > > Tools: > > Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in > LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing > in the future. > > * DumpRenderTree/chromium/TestWebPlugin.cpp: > (TestWebPlugin::initialize): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebPluginContainer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.cpp View 4 chunks +20 lines, -0 lines 0 comments Download
M Tools/ChangeLog View 1 chunk +14 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestWebPlugin.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
8 years ago (2012-12-03 18:48:09 UTC) #1
Yusuke Sato
8 years ago (2012-12-03 19:17:10 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698