Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 11411287: Send 'IP address changed' events on Android when connection type changes. (Closed)

Created:
8 years ago by Philippe
Modified:
8 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, digit1, felipeg, pasko-google - do not use
Visibility:
Public.

Description

Send 'IP address changed' events on Android when connection type changes. NetworkChangeNotifierAndroid was only firing 'network connection changed' events although many clients subscribe to 'IP address changed events'. One of them is ClientSocketPoolBaseHelper which invalidates its socket pool whenever the IP address changes. The lack of this notification on Android could have led to an invalid socket being used. This is a first approach. Later on this can be improved to only fire the notification when the IP address actually changed. This issue was found as part of the following bug investigation although this CL doesn't claim to fix the bug. BUG=149231 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/android/network_change_notifier_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Philippe
8 years ago (2012-11-30 17:39:16 UTC) #1
szym
lgtm
8 years ago (2012-11-30 18:45:45 UTC) #2
felipeg
Totally awesome. LGTM
8 years ago (2012-11-30 18:49:47 UTC) #3
Ryan Sleevi
lgtm
8 years ago (2012-11-30 18:55:41 UTC) #4
Philippe
On 2012/11/30 18:55:41, Ryan Sleevi wrote: > lgtm Thanks guys!
8 years ago (2012-12-03 09:27:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411287/1
8 years ago (2012-12-03 09:27:33 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 13:19:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411287/1
8 years ago (2012-12-03 13:22:14 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 13:49:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11411287/1
8 years ago (2012-12-03 15:42:29 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-03 16:34:39 UTC) #11
Retried try job too often on linux_rel for step(s) ash_unittests

Powered by Google App Engine
This is Rietveld 408576698