printing/printing_context_win.cc - Issue 11411286: Decouple IsMetroProcess() calls, introducing IsSingleWindowMetroMode().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_win.cc

Issue 11411286: Decouple IsMetroProcess() calls, introducing IsSingleWindowMetroMode(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r170746 Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/printing_context_win.cc

diff --git a/printing/printing_context_win.cc b/printing/printing_context_win.cc

index b5d05519de391d2913629810d1764af516520d9b..8e0f0e11893df996ba0dbcfe0777f89dbbbbc051 100644

--- a/printing/printing_context_win.cc

+++ b/printing/printing_context_win.cc

@@ -23,6 +23,7 @@

#include "printing/printed_document.h"

#include "printing/units.h"

#include "skia/ext/platform_device.h"

+#include "win8/util/win8_util.h"

using base::Time;

@@ -223,7 +224,7 @@ void PrintingContextWin::AskUserForSettings(

#if !defined(USE_AURA)

DCHECK(!in_print_job_);

- if (base::win::IsMetroProcess()) {

+ if (win8::IsSingleWindowMetroMode()) {

// The system dialog can not be opened while running in Metro.

cpu_(ooo_6.6-7.5) 2012/12/03 20:56:26 this seems incorrect as in ash we don't want this

gab 2012/12/04 00:19:06 This is already precompiled out for AURA builds (s

// But we can programatically launch the Metro print device charm though.

HMODULE metro_module = base::win::GetMetroModule();

« chrome/browser/ui/views/task_manager_view.cc ('K') | « printing/print_destination_win.cc ('k') | win8/util/win8_util.h » ('j') | no next file with comments »