Decouple IsMetroProcess() calls, introducing IsSingleWindowMetroMode().

chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
index 9e182989d2bdd0ff756e523be7dbbf2bd9de40c3..ee5f3e4e35213a20e50a493df8e79d330004c38d 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc
@@ -1742,7 +1742,7 @@ LRESULT OmniboxViewWin::OnMouseActivate(HWND window,
     if (gaining_focus_) {
       // On Windows 8 in metro mode, we get two WM_MOUSEACTIVATE messages when
       // we click on the omnibox with the mouse.
-      DCHECK(base::win::IsMetroProcess());
+      DCHECK(win8::IsSingleWindowMetroMode());

[cpu_(ooo_6.6-7.5), 2012/12/03 20:56:26]

not familiar with this change, again consider this for a second CL.

[gab, 2012/12/04 00:19:06]

This was added by ananta in https://codereview.chromium.org/11098077, I don't
think this code path is even used in an AURA build (does the AURA build  use
omnibox_view_win.cc?) and even if it does, I don't think we would be subject to
this bad behavior?

In doubt I can leave this out, but I'd rather keep it all together.

[cpu_(ooo_6.6-7.5), 2012/12/04 01:17:39]

Like I said, all other things equal you should prefer smaller CLs, but if you
insists then add ananta to the review.

On 2012/12/04 00:19:06, gab wrote:

[gab, 2012/12/04 18:47:42]

Ok, leaving out for now.

[gab, 2012/12/04 19:04:31]

Reconsidered, leaving it in since this file isn't even compiled in on AURA so
this is definitely the right choice:
https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/chrome_browser_ui.....

       return result;
     }
     gaining_focus_.reset(new ScopedFreeze(this, GetTextObjectModel()));