Decouple IsMetroProcess() calls, introducing IsSingleWindowMetroMode().

chrome/browser/ui/views/task_manager_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/task_manager.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/metrics/stats_table.h"
 #include "base/utf_string_conversions.h"
@@ skipping 20 matching lines @@
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/controls/menu/menu.h"
 #include "ui/views/controls/table/group_table_model.h"
 #include "ui/views/controls/table/group_table_view.h"
 #include "ui/views/controls/table/table_view_observer.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/window/dialog_delegate.h"
 
 #if defined(OS_WIN)
-#include "base/win/metro.h"
+#include "win8/util/win8_util.h"
 #endif
 
 // The task manager window default size.
 static const int kDefaultWidth = 460;
 static const int kDefaultHeight = 270;
 
 // Yellow highlight used when highlighting background resources.
 static const SkColor kBackgroundResourceHighlight =
     SkColorSetRGB(0xff, 0xf1, 0xcd);
 
@@ skipping 527 matching lines @@
       link_prefered_height);
 }
 
 gfx::Size TaskManagerView::GetPreferredSize() {
   return gfx::Size(kDefaultWidth, kDefaultHeight);
 }
 
 // static
 void TaskManagerView::Show(bool highlight_background_resources) {
   // In Windows Metro it's not good to open this native window.
-  DCHECK(!base::win::IsMetroProcess());
+  DCHECK(!win8::IsSingleWindowMetroMode());
 

[cpu_(ooo_6.6-7.5), 2012/12/03 20:56:26]

FYI, There is a discussion about what task manager to show; the native one
cannot be shown and the webview based should not be shown.

[gab, 2012/12/04 00:19:06]

So making this change only enables (and some other related to task manager in
this CL) showing the Task Manager -- this fails for now as it tries to create a
native window, but in the end we do want a task manager in Ash right?

In fact this change doesn't do much as is anyways since this will run in the
browser process which was already not an immersive process by Robert's recent
redesign.

The purpose of this change is more to highlight which things are meant to be
turned ON/OFF specifically for non-ash Metro mode.

[gab, 2012/12/04 18:47:42]

Looks like task_manager_view.cc is already compiled out on AURA builds:
https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/chrome_browser_ui....

So this is definitely a case of win8::IsSingleWindowMetroMode().

   if (instance_) {
     if (instance_->highlight_background_resources_ !=
         highlight_background_resources) {
       instance_->GetWidget()->Close();
     } else {
       // If there's a Task manager window open already, just activate it.
       instance_->GetWidget()->Activate();
       return;
     }
   }
@@ skipping 206 matching lines @@
 // Declared in browser_dialogs.h so others don't need to depend on our header.
 void ShowTaskManager() {
   TaskManagerView::Show(false);
 }
 
 void ShowBackgroundPages() {
   TaskManagerView::Show(true);
 }
 
 }  // namespace chrome