Sync FileSystem: Use app id part of the URL for its directory title.

Sync FileSystem: Use app id part of the URL for its directory title.


- This CL changes the directory title for origins, from "chrome-extension://exampleextension" to "exampleextension"
- Also, drops file name escape.

BUG=163554
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170887

[tzik, 2012-11-30 07:06:24]

PTAL.

[kinuko, 2012-11-30 07:13:28]

Thx!

A bug for you: https://code.google.com/p/chromium/issues/detail?id=163554

lgtm, but could we use 'example' or 'hoge' or anything rather than
'www.example.com' for test IDs?

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc
(right):

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:390: const
GURL kOrigin2("chrome-extension://hoge.example.com");
could we also replace the host part with more plausible ones? (e.g. 'example' or
'hoge')

[nhiroki, 2012-11-30 09:17:54]

lgtm

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.cc:27: #include
"net/base/escape.h"
No longer unused?

[tzik, 2012-12-03 08:12:08]

Thanks!

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.cc:27: #include
"net/base/escape.h"
On 2012/11/30 09:17:54, nhiroki wrote:
> No longer unused?

Done.

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc
(right):

https://codereview.chromium.org/11411280/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:390: const
GURL kOrigin2("chrome-extension://hoge.example.com");
On 2012/11/30 07:13:28, kinuko wrote:
> could we also replace the host part with more plausible ones? (e.g. 'example'
or
> 'hoge')

Done.

[commit-bot: I haz the power, 2012-12-03 08:12:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/11411280/34

[commit-bot: I haz the power, 2012-12-03 12:16:48]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 01:32:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/11411280/34