Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/password_manager/password_manager_delegate_impl.cc

Issue 11411267: Make sure to display an errors that occur during the chrome sign in process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ntp bubble Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_delegate_impl.cc
diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc
index 65484795e278c1b3577893c2033749a8c75c561e..045e279b2b809d9fec8f4d9d3029c432bb163655 100644
--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc
+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc
@@ -153,12 +153,15 @@ void PasswordManagerDelegateImpl::AddSavePasswordInfoBarIfPermitted(
// For now, one-click signin is fully implemented only on windows.
#if defined(ENABLE_ONE_CLICK_SIGNIN)
GURL realm(form_to_save->realm());
+ int error_message_id = 0;
Andrew T Wilson (Slow) 2012/12/03 14:54:49 I guess we're trying to ignore the error message s
Roger Tawa OOO till Jul 10th 2012/12/03 22:26:54 Done.
// TODO(mathp): Checking only against associated_username() causes a bug
// referenced here: crbug.com/133275
if ((realm == GURL(GaiaUrls::GetInstance()->gaia_login_form_realm()) ||
realm == GURL("https://www.google.com/")) &&
OneClickSigninHelper::CanOffer(web_contents_,
- UTF16ToUTF8(form_to_save->associated_username()), true)) {
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ UTF16ToUTF8(form_to_save->associated_username()),
+ &error_message_id)) {
return;
}
#endif
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | chrome/browser/ui/sync/one_click_signin_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698