Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

Issue 11411267: Make sure to display an errors that occur during the chrome sign in process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ntp bubble Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/sync_promo/sync_promo_handler.h" 5 #include "chrome/browser/ui/webui/sync_promo/sync_promo_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 SyncPromoHandler::~SyncPromoHandler() { 74 SyncPromoHandler::~SyncPromoHandler() {
75 } 75 }
76 76
77 // static 77 // static
78 void SyncPromoHandler::RegisterUserPrefs(PrefService* prefs) { 78 void SyncPromoHandler::RegisterUserPrefs(PrefService* prefs) {
79 prefs->RegisterIntegerPref(prefs::kSyncPromoViewCount, 0, 79 prefs->RegisterIntegerPref(prefs::kSyncPromoViewCount, 0,
80 PrefService::UNSYNCABLE_PREF); 80 PrefService::UNSYNCABLE_PREF);
81 prefs->RegisterBooleanPref(prefs::kSyncPromoShowNTPBubble, false, 81 prefs->RegisterBooleanPref(prefs::kSyncPromoShowNTPBubble, false,
82 PrefService::UNSYNCABLE_PREF); 82 PrefService::UNSYNCABLE_PREF);
83 prefs->RegisterStringPref(prefs::kSyncPromoErrorMessage, std::string(),
84 PrefService::UNSYNCABLE_PREF);
83 } 85 }
84 86
85 void SyncPromoHandler::RegisterMessages() { 87 void SyncPromoHandler::RegisterMessages() {
86 // Keep a reference to the preferences service for convenience and it's 88 // Keep a reference to the preferences service for convenience and it's
87 // probably a little faster that getting it via Profile::FromWebUI() every 89 // probably a little faster that getting it via Profile::FromWebUI() every
88 // time we need to interact with preferences. 90 // time we need to interact with preferences.
89 prefs_ = Profile::FromWebUI(web_ui())->GetPrefs(); 91 prefs_ = Profile::FromWebUI(web_ui())->GetPrefs();
90 DCHECK(prefs_); 92 DCHECK(prefs_);
91 // Ignore events from view-source:chrome://signin. 93 // Ignore events from view-source:chrome://signin.
92 if (!web_ui()->GetWebContents()->GetController().GetActiveEntry()-> 94 if (!web_ui()->GetWebContents()->GetController().GetActiveEntry()->
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // Send an enumeration to our single user flow histogram. 282 // Send an enumeration to our single user flow histogram.
281 UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action, 283 UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action,
282 SYNC_PROMO_BUCKET_BOUNDARY); 284 SYNC_PROMO_BUCKET_BOUNDARY);
283 } 285 }
284 286
285 void SyncPromoHandler::CloseUI() { 287 void SyncPromoHandler::CloseUI() {
286 // Callers should not ever try to close the promo UI (should only call 288 // Callers should not ever try to close the promo UI (should only call
287 // CloseUI() if the user is already logged in). 289 // CloseUI() if the user is already logged in).
288 NOTREACHED() << "Cannot close the promo UI"; 290 NOTREACHED() << "Cannot close the promo UI";
289 } 291 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698