Make sure to display an errors that occur during the chrome sign in process

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 245 matching lines @@
     return false;
 
   return profile->GetOriginalProfile()->IsSyncAccessible();
 #endif
 }
 
 // static
 void NTPLoginHandler::GetLocalizedValues(Profile* profile,
                                          DictionaryValue* values) {
   PrefService* prefs = profile->GetPrefs();
-  bool hide_sync = prefs->GetString(prefs::kGoogleServicesUsername).empty() ||
-      !prefs->GetBoolean(prefs::kSyncPromoShowNTPBubble);
+  std::string error_message = prefs->GetString(prefs::kSyncPromoErrorMessage);
+  bool hide_sync = !prefs->GetBoolean(prefs::kSyncPromoShowNTPBubble);

[Andrew T Wilson (Slow), 2012/12/03 14:54:49]

Will this have unexpected side effects with old promo messages getting displayed
despite the user being signed in?

Also, what's the desired behavior here - are we going to keep displaying the
signin error forever, or does something clear it?

[Roger Tawa OOO till Jul 10th, 2012/12/03 22:26:54]

The bubble clears the error message once the user has seen it.

I did not see any problems with the old promo, but I'll take a closer look.

 
-  values->SetString("login_status_message",
+  string16 message =
       hide_sync ? string16() :
-      l10n_util::GetStringFUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE,
-          l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
+          !error_message.empty() ? UTF8ToUTF16(error_message) :
+              l10n_util::GetStringFUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE,
+                  l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
+
+  values->SetString("login_status_message", message);
   values->SetString("login_status_url",
       hide_sync ? std::string() : chrome::kSyncLearnMoreURL);
   values->SetString("login_status_advanced",
-      hide_sync ? string16() :
+      hide_sync || !error_message.empty() ? string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_ADVANCED));
   values->SetString("login_status_dismiss",
       hide_sync ? string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_OK));
 }