Make sure to display an errors that occur during the chrome sign in process

chrome/browser/ui/tab_contents/tab_contents.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "chrome/browser/autofill/autofill_external_delegate.h"
@@ skipping 170 matching lines @@
   printing::PrintPreviewMessageHandler::CreateForWebContents(contents);
   printing::PrintViewManager::CreateForWebContents(contents);
 #endif
 
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
   // If this is not an incognito window, setup to handle one-click login.
   // We don't want to check that the profile is already connected at this time
   // because the connected state may change while this tab is open.  Having a
   // one-click signin helper attached does not cause problems if the profile
   // happens to be already connected.
-  if (OneClickSigninHelper::CanOffer(contents, "", false))
-      OneClickSigninHelper::CreateForWebContents(contents);
+  int error_message_id = 0;
+  if (OneClickSigninHelper::CanOffer(contents,

[Andrew T Wilson (Slow), 2012/12/03 14:54:49]

Consider just passing null here for error_message_id.

[Roger Tawa OOO till Jul 10th, 2012/12/03 22:26:54]

Done.

+          OneClickSigninHelper::CAN_OFFER_FOR_ALL, "", &error_message_id))
+    OneClickSigninHelper::CreateForWebContents(contents);
 #endif
 
 #if defined(OS_WIN)
   MetroPinTabHelper::CreateForWebContents(contents);
 #endif
 }
 
 TabContents::~TabContents() {
   in_destructor_ = true;
 }
@@ skipping 27 matching lines @@
 
 void TabContents::WebContentsDestroyed(WebContents* tab) {
   if (!in_destructor_) {
     // The owned WebContents is being destroyed independently, so delete this.
     ignore_result(owned_web_contents_.release());
     TabContentsUserData* user_data = static_cast<TabContentsUserData*>(
         tab->GetUserData(&kTabContentsUserDataKey));
     user_data->MakeContentsOwned();
   }
 }