Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 11411250: Immersive mode reveals the tabstrip/omnibox on top of web content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix window close Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/accelerator_controller.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/immersive_mode_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index e535c3283791dbf08a637b84075913d601563e74..8ffe4dcb1109e4face6fcb9df55feb5d550c7e3b 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -99,6 +99,10 @@ class BrowserView : public BrowserWindow,
public:
// The browser view's class name.
static const char kViewClassName[];
+ // Initial child indices for well-known views.
+ static const int kTabstripIndex;
+ static const int kInfoBarIndex;
+ static const int kToolbarIndex;
explicit BrowserView(Browser* browser);
virtual ~BrowserView();
@@ -577,37 +581,32 @@ class BrowserView : public BrowserWindow,
// BrowserView layout (LTR one is pictured here).
//
- // ----------------------------------------------------------------
- // | Tabs (1) |
- // |--------------------------------------------------------------|
- // | Navigation buttons, menus and the address bar (toolbar_) |
- // |--------------------------------------------------------------|
- // | All infobars (infobar_container_) * |
- // |--------------------------------------------------------------|
- // | Bookmarks (bookmark_bar_view_) * |
- // |--------------------------------------------------------------|
- // |Page content (contents_) ||
- // |-------------------------------------------------------------||
- // || contents_container_ and/or |||
- // || preview_controller_->preview_container_ |||
- // || |||
- // || |||
- // || |||
- // || |||
- // || |||
- // |-------------------------------------------------------------||
- // |==(2)=========================================================|
- // | |
- // | |
- // | Debugger (devtools_container_) |
- // | |
- // | |
- // |--------------------------------------------------------------|
- // | Active downloads (download_shelf_) |
- // ----------------------------------------------------------------
- //
- // (1) - tabstrip_, default position
- // (2) - contents_split_
+ // --------------------------------------------------------------------
+ // | Tabs (tabstrip_) |
+ // |------------------------------------------------------------------|
+ // | Navigation buttons, menus and the address bar (toolbar_) |
+ // |------------------------------------------------------------------|
+ // | All infobars (infobar_container_) * |
+ // |------------------------------------------------------------------|
+ // | Bookmarks (bookmark_bar_view_) * |
+ // |------------------------------------------------------------------|
+ // | Debugger splitter (contents_split_) |
+ // | +------------------------------------------------------------+ |
+ // | | Page content (contents_) | |
+ // | | +------------------------------------------------------+ | |
+ // | | | contents_container_ and/or | | |
+ // | | | preview_controller_->preview_container_ | | |
+ // | | | | | |
+ // | | | | | |
+ // | | +------------------------------------------------------+ | |
+ // | +------------------------------------------------------------+ |
+ // | +------------------------------------------------------------+ |
+ // | | Debugger (devtools_container_) | |
+ // | | | |
+ // | +------------------------------------------------------------+ |
+ // |------------------------------------------------------------------|
+ // | Active downloads (download_shelf_) |
+ // --------------------------------------------------------------------
//
sky 2012/11/29 19:30:23 Can you also add a comment about reveal mode.
James Cook 2012/11/29 21:20:59 Done.
// * - The bookmark bar and info bar are swapped when on the new tab page.
// Additionally contents_ is positioned on top of the bookmark bar when
« no previous file with comments | « ash/accelerators/accelerator_controller.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/immersive_mode_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698