Issue 11411247: Support 3f swipe for tab scrubbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411247: Support 3f swipe for tab scrubbing (Closed)

Created:
8 years ago by DaveMoore

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support 3f swipe for tab scrubbing Tests will be added if we like approach and take out from behind flag. BUG=124830 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170138 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170208

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -46 lines)			Patch
M	chrome/browser/ui/views/ash/tab_scrubber.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/tab_scrubber.cc	View	3 chunks	+58 lines, -33 lines	2 comments	Download
M	ui/base/events/event.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/base/events/event.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/events/event_utils.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/base/x/events_x.cc	View	10 chunks	+21 lines, -4 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years ago (2012-11-28 23:36:19 UTC) #2

LGTM

https://codereview.chromium.org/11411247/diff/1/chrome/browser/ui/views/ash/t...
File chrome/browser/ui/views/ash/tab_scrubber.cc (right):

https://codereview.chromium.org/11411247/diff/1/chrome/browser/ui/views/ash/t...
chrome/browser/ui/views/ash/tab_scrubber.cc:31: const int kInitialTabOffset =
10;
nit: constants before methods, and add a description.

https://codereview.chromium.org/11411247/diff/1/chrome/browser/ui/views/ash/t...
chrome/browser/ui/views/ash/tab_scrubber.cc:72:
BrowserView::GetBrowserViewForNativeWindow(
BrowserView::GetBrowserViewForBrowser(browser);

Expand Messages | Collapse Messages