Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 11411245: Merge 135804 - Check for empty perContextData while creating NP V8 Object. (Closed)

Created:
8 years ago by karen
Modified:
8 years ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135804 - Check for empty perContextData while creating NP V8 Object. https://bugs.webkit.org/show_bug.cgi?id=98448 Patch by Istiaque Ahmed <lazyboy@chromium.org>; on 2012-11-26 Reviewed by Adam Barth. Fixes crash in npCreateV8ScriptObject(), if NP Invoke is called from a document that is no longer displayed in frame (isCurrentlyDisplayedInFrame() == false), we have empty perContextData and this results in invalid memory access. Source/WebCore: Test: platform/chromium/plugins/empty-per-context-data.html * bindings/v8/NPV8Object.cpp: (WebCore::npCreateV8ScriptObject): LayoutTests: * platform/chromium/plugins/empty-per-context-data-expected.txt: Added. * platform/chromium/plugins/empty-per-context-data.html: Added. * platform/chromium/plugins/resources/script-container.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
A + LayoutTests/platform/chromium/plugins/empty-per-context-data.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/empty-per-context-data-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/resources/script-container.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/bindings/v8/NPV8Object.cpp View 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years ago (2012-11-28 22:55:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698