runtime/vm/dart_api_impl.cc - Issue 11411204: When externalizing a string ensure that the basic tag bits are preserved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11411204: When externalizing a string ensure that the basic tag bits are preserved. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 15532)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -1749,6 +1749,10 @@

if (array == NULL) {

RETURN_NULL_ERROR(array);

}

+ if (str_obj.IsCanonical()) {

+ return Api::NewError("Dart_MakeExternalString "

+ "cannot externalize a read-only string.");

Anton Muhin 2012/11/30 21:37:45 might be worth clarifying what's the difference be

+ }

intptr_t str_size = (str_obj.Length() * str_obj.CharSize());

if ((length < str_size) || (length > String::kMaxElements)) {

return Api::NewError("Dart_MakeExternalString "

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »