Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 11411189: Fix typo'd usage of OS_MAC vs OS_MACOSX! (Closed)

Created:
8 years ago by DaleCurtis
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix typo'd usage of OS_MAC vs OS_MACOSX! __Now__ renderer side mixing is enabled on Mac :-/ BUG=162768 TEST=audio works, tests pass. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173253

Patch Set 1 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/render_audiosourceprovider.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
DaleCurtis
/shamme!!! almost as bad as a missing return :)
8 years ago (2012-11-27 01:54:11 UTC) #1
scherkus (not reviewing)
lgtm
8 years ago (2012-11-27 02:16:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11411189/1
8 years ago (2012-11-28 02:18:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 11411189-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-28 02:18:54 UTC) #4
DaleCurtis
tbr=sky for content/browser/renderer_host/render_process_host_impl.cc update.
8 years ago (2012-11-28 02:21:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11411189/1
8 years ago (2012-11-28 02:31:25 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-28 05:00:40 UTC) #7
Retried try job too often on mac_rel for step(s) content_browsertests

Powered by Google App Engine
This is Rietveld 408576698