move favicon download code from chrome/ into content/

chrome/browser/favicon/favicon_download_helper.h

Index: chrome/browser/favicon/favicon_download_helper.h
diff --git a/chrome/browser/favicon/favicon_download_helper.h b/chrome/browser/favicon/favicon_download_helper.h
index 195b3354da5b47dfdf0d6492f62cffd3eac154c5..e76b614a1ac744cab45b7a2ea6486849d76c408c 100644
--- a/chrome/browser/favicon/favicon_download_helper.h
+++ b/chrome/browser/favicon/favicon_download_helper.h
@@ -9,8 +9,8 @@
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
-#include "chrome/common/favicon_url.h"
 #include "content/public/browser/web_contents_observer.h"
+#include "content/public/common/favicon_url.h"
 
 namespace content {
 class WebContents;
@@ -33,10 +33,10 @@ class FaviconDownloadHelper : public content::WebContentsObserver {
 
   virtual ~FaviconDownloadHelper();
 
-  // Download the favicon at |url|. Returns the unique id of the download
-  // request. The id will be passed to
-  // FaviconDownloadHelperDelegate::OnDidDownloadFavicon() once the favicon has
-  // been retrieved.
+  // Starts the download of the given favicon |url| and returns the unique id of
+  // the download request. When the download is finished, an
+  // IconHostMsg_DidDownloadFavicon IPC message will be sent and passed on to

[jam, 2012/11/27 01:16:31]

nit: don't describe the implementation details, especially from another module,
in the method's comment

[Cait (Slow), 2012/11/28 00:11:45]

Done.

+  // the delegate via FaviconDownloadHelperDelegate::OnDidDownloadFavicon().
   // Note that |image_size| is a hint for images with multiple sizes. The
   // downloaded image is not resized to the given image_size. If 0 is passed,
   // the first frame of the image is returned.
@@ -61,7 +61,7 @@ class FaviconDownloadHelper : public content::WebContentsObserver {
   // Message Handler, called when the FaviconURL associated with the specified
   // page is updated.
   void OnUpdateFaviconURL(int32 page_id,
-                          const std::vector<FaviconURL>& candidates);
+                          const std::vector<content::FaviconURL>& candidates);
 
   // Delegate to pass Favicon bitmaps back to. Weak.
   FaviconDownloadHelperDelegate* delegate_;