move favicon download code from chrome/ into content/

content/public/browser/web_contents.h

Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index cab59f04bc062e0206b3a1a294ff28e94e41afb6..0b0ad43169e80cb19ec3131e67e47ca4ed7be609 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -36,6 +36,7 @@ struct LoadStateWithParam;
 namespace content {
 
 class BrowserContext;
+class FaviconDownloadDelegate;
 class InterstitialPage;
 class RenderProcessHost;
 class RenderViewHost;
@@ -393,6 +394,18 @@ class WebContents : public PageNavigator,
 
   // Does this have an opener associated with it?
   virtual bool HasOpener() const = 0;
+
+  // Starts the download of the given favicon |url| and returns the unique id of
+  // the download request. When the download is finished, an
+  // IconHostMsg_DidDownloadFavicon IPC message will be sent and passed on to
+  // the delegate via FaviconDownloadDelegate::DidDownloadFavicon().
+  // Note that |image_size| is a hint for images with multiple sizes. The
+  // downloaded image is not resized to the given image_size. If 0 is passed,
+  // the first frame of the image is returned.
+  virtual int DownloadFavicon(const GURL& url, int image_size) = 0;

[jam, 2012/11/27 01:16:31]

nit: comment is out of date (re IPC)

seems that a simpler API is to have this function takes a
FaviconDownloadDelegate as a parameter? then that way you wouldn't need
RegisterFaviconDelegate. this would also avoid the issue of a delegate being
overwritten if multiple classes fetch favicons from the same webcontents

[Cait (Slow), 2012/11/28 00:11:45]

Fixed the comment. Unfortunately, the delegate has to be set prior to the
download request being made in order to receive the new faviconURL from the
renderer (this is the purpose of the UpdateFaviconURL method on the delegate).

On 2012/11/27 01:16:31, John Abd-El-Malek wrote:

[jam, 2012/11/28 04:08:16]

can the updated url be saved in WebContents until a download is requested and
then given to the delegate then? my concern is that it will be error prone to
have a way to set a delegate which can be overwridden by other objects

+
+  virtual void RegisterFaviconDelegate(FaviconDownloadDelegate* delegate) = 0;
+
 };
 
 }  // namespace content