Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 11411147: Address review comments on issue 11412105. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 15278)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -503,18 +503,6 @@
status = STATUS_CLOSED;
}
- // TODO(kasperl): I really don't want to pass the compiler into this
- // method. Maybe we need a better logging framework.
- void printToCompiler(Compiler compiler) {
- HInstruction instruction = first;
- while (instruction != null) {
- int instructionId = instruction.id;
- String inputsAsString = instruction.inputsToString();
- compiler.log('$instructionId: $instruction $inputsAsString');
- instruction = instruction.next;
- }
- }
-
void addAtEntry(HInstruction instruction) {
assert(instruction is !HPhi);
super.addBefore(first, instruction);
@@ -1285,12 +1273,10 @@
HInstruction get condition => inputs[0];
HBasicBlock get trueBranch => block.successors[0];
HBasicBlock get falseBranch => block.successors[1];
- toString();
}
abstract class HControlFlow extends HInstruction {
HControlFlow(inputs) : super(inputs);
- toString();
void prepareGvn(HTypeMap types) {
// Control flow does not have side-effects.
}
@@ -1306,9 +1292,6 @@
*/
HInvoke(List<HInstruction> inputs) : super(inputs);
static const int ARGUMENTS_OFFSET = 1;
-
- // TODO(floitsch): make class abstract instead of adding an abstract method.
- accept(HVisitor visitor);
}
abstract class HInvokeDynamic extends HInvoke {
@@ -1320,8 +1303,6 @@
toString() => 'invoke dynamic: $selector';
HInstruction get receiver => inputs[0];
- accept(HVisitor visitor);
-
bool get isInterceptorCall {
// We know it's a selector call if it follows the interceptor
// calling convention, which adds the actual receiver as a
@@ -1350,8 +1331,6 @@
this.isSideEffectFree)
: super(selector, element, inputs);
toString() => 'invoke dynamic field: $selector';
-
- accept(HVisitor visitor);
}
class HInvokeDynamicGetter extends HInvokeDynamicField {
@@ -1756,9 +1735,6 @@
if (left.isTypeUnknown(types)) return HType.INTEGER;
return HType.UNKNOWN;
}
-
- // TODO(floitsch): make class abstract instead of adding an abstract method.
- accept(HVisitor visitor);
}
class HShiftLeft extends HBinaryBitOp {
@@ -2230,8 +2206,6 @@
bool isBuiltin(HTypeMap types)
=> left.isNumber(types) && right.isNumber(types);
- // TODO(1603): the class should be marked as abstract.
- BinaryOperation operation(ConstantSystem constantSystem);
}
class HEquals extends HRelational {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698