Address review comments on issue 11412105.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	(revision 15278)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	(working copy)
@@ -1724,6 +1724,7 @@
     use(node.receiver);
     if (node.element == backend.jsArrayLength
         || node.element == backend.jsStringLength) {
+      // The 'length' name should not be mangled.

[ahe, 2012/11/23 13:05:03]

But why? :-)

[ngeoffray, 2012/11/23 13:07:53]

Done.

       push(new js.PropertyAccess.field(pop(), 'length'), node);
     } else {
       String name = backend.namer.getName(node.element);
@@ -1737,21 +1738,6 @@
     }
   }
 
-  // Determine if an instruction is a simple number computation
-  // involving only things with guaranteed number types and a given
-  // field.
-  bool isSimpleFieldNumberComputation(HInstruction value, HFieldSet node) {
-    if (value.guaranteedType.union(HType.NUMBER, compiler) == HType.NUMBER) {
-      return true;
-    }
-    if (value is HBinaryArithmetic) {
-      return (isSimpleFieldNumberComputation(value.left, node) &&
-              isSimpleFieldNumberComputation(value.right, node));
-    }
-    if (value is HFieldGet) return value.element == node.element;
-    return false;
-  }
-
   visitFieldSet(HFieldSet node) {
     String name = backend.namer.getName(node.element);
     DartType type = types[node.receiver].computeType(compiler);