Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 11411142: Support loads from Uint8Array and ExternalUint8Array in the optimizing compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 15254)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -1142,12 +1142,14 @@
RawAbstractType* LoadIndexedInstr::CompileType() const {
switch (class_id_) {
case kArrayCid:
- case kGrowableObjectArrayCid:
case kImmutableArrayCid:
return Type::DynamicType();
case kFloat32ArrayCid :
case kFloat64ArrayCid :
return Type::Double();
+ case kUint8ArrayCid:
+ case kExternalUint8ArrayCid:
+ return Type::IntType();
default:
UNIMPLEMENTED();
return Type::IntType();
@@ -1158,12 +1160,14 @@
intptr_t LoadIndexedInstr::ResultCid() const {
switch (class_id_) {
case kArrayCid:
- case kGrowableObjectArrayCid:
case kImmutableArrayCid:
return kDynamicCid;
case kFloat32ArrayCid :
case kFloat64ArrayCid :
return kDoubleCid;
+ case kUint8ArrayCid:
+ case kExternalUint8ArrayCid:
+ return kSmiCid;
default:
UNIMPLEMENTED();
return kSmiCid;
@@ -1174,8 +1178,9 @@
Representation LoadIndexedInstr::representation() const {
switch (class_id_) {
case kArrayCid:
- case kGrowableObjectArrayCid:
case kImmutableArrayCid:
+ case kUint8ArrayCid:
+ case kExternalUint8ArrayCid:
return kTagged;
case kFloat32ArrayCid :
case kFloat64ArrayCid :
@@ -1198,8 +1203,6 @@
ASSERT(idx == 2);
switch (class_id_) {
case kArrayCid:
- case kGrowableObjectArrayCid:
- case kImmutableArrayCid:
return kTagged;
case kFloat32ArrayCid :
case kFloat64ArrayCid :
@@ -2437,6 +2440,20 @@
}
+void LoadIndexedInstr::InferRange() {
+ switch (class_id()) {
+ case kExternalUint8ArrayCid:
+ case kUint8ArrayCid:
+ range_ = new Range(RangeBoundary::FromConstant(0),
+ RangeBoundary::FromConstant(255));
+ break;
+ default:
+ Definition::InferRange();
+ break;
+ }
+}
+
+
void PhiInstr::InferRange() {
RangeBoundary new_min;
RangeBoundary new_max;
@@ -2662,6 +2679,10 @@
case kArrayCid:
case kImmutableArrayCid:
return Array::length_offset();
+ case kUint8ArrayCid:
+ return Uint8Array::length_offset();
+ case kExternalUint8ArrayCid:
+ return ByteArray::length_offset();
default:
UNREACHABLE();
return -1;
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698