Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 11411142: Support loads from Uint8Array and ExternalUint8Array in the optimizing compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 15254)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -954,7 +954,6 @@
intptr_t offset) {
switch (cid) {
case kArrayCid:
- case kGrowableObjectArrayCid:
case kImmutableArrayCid: {
const intptr_t disp = offset * kWordSize + sizeof(RawArray);
ASSERT(Utils::IsInt(31, disp));
@@ -972,10 +971,37 @@
ASSERT(Utils::IsInt(31, disp));
return FieldAddress(array, disp);
}
+ case kUint8ArrayCid: {
+ const intptr_t disp = offset + Uint8Array::data_offset();
+ ASSERT(Utils::IsInt(31, disp));
+ return FieldAddress(array, disp);
+ }
default:
UNIMPLEMENTED();
return FieldAddress(SPREG, 0);
}
}
+
+FieldAddress FlowGraphCompiler::ElementAddressForRegIndex(intptr_t cid,
+ Register array,
+ Register index) {
+ // Note that index is Smi, i.e, times 2.
+ ASSERT(kSmiTagShift == 1);
+ switch (cid) {
+ case kArrayCid:
+ case kImmutableArrayCid:
+ return FieldAddress(array, index, TIMES_HALF_WORD_SIZE, sizeof(RawArray));
+ case kFloat32ArrayCid:
+ return FieldAddress(array, index, TIMES_2, Float32Array::data_offset());
+ case kFloat64ArrayCid:
+ return FieldAddress(array, index, TIMES_4, Float64Array::data_offset());
+ case kUint8ArrayCid:
+ return FieldAddress(array, index, TIMES_1, Uint8Array::data_offset());
+ default:
+ UNIMPLEMENTED();
+ return FieldAddress(SPREG, 0);
+ }
+}
+
} // namespace dart
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698