Support loads from Uint8Array and ExternalUint8Array in the optimizing compiler.

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
@@ skipping 936 matching lines @@
       return false;
   }
 }
 
 
 FieldAddress FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
                                                           Register array,
                                                           intptr_t offset) {
   switch (cid) {
     case kArrayCid:
     case kGrowableObjectArrayCid:

[srdjan, 2012/11/22 18:18:19]

Can we remove kGrowableObjectArrayCid here as well?

[Florian Schneider, 2012/11/23 14:49:39]

Yes, good point.

     case kImmutableArrayCid: {
       const intptr_t disp = offset * kWordSize + sizeof(RawArray);
       ASSERT(Utils::IsInt(31, disp));
       return FieldAddress(array, disp);
     }
     case kFloat32ArrayCid: {
       const intptr_t disp =
           offset * kFloatSize + Float32Array::data_offset();
       ASSERT(Utils::IsInt(31, disp));
       return FieldAddress(array, disp);
     }
     case kFloat64ArrayCid: {
       const intptr_t disp =
           offset * kDoubleSize + Float64Array::data_offset();
       ASSERT(Utils::IsInt(31, disp));
       return FieldAddress(array, disp);
     }
+    case kUint8ArrayCid: {
+      const intptr_t disp = offset + Uint8Array::data_offset();
+      ASSERT(Utils::IsInt(31, disp));
+      return FieldAddress(array, disp);
+    }
     default:
       UNIMPLEMENTED();
       return FieldAddress(SPREG, 0);
   }
 }
 
+
+FieldAddress FlowGraphCompiler::ElementAddressForRegIndex(intptr_t cid,
+                                                          Register array,
+                                                          Register index) {
+  // Note that index is Smi, i.e, times 2.
+  ASSERT(kSmiTagShift == 1);
+  switch (cid) {
+    case kArrayCid:
+    case kImmutableArrayCid:
+      return FieldAddress(array, index, TIMES_HALF_WORD_SIZE, sizeof(RawArray));
+    case kFloat32ArrayCid:
+      return FieldAddress(array, index, TIMES_2, Float32Array::data_offset());
+    case kFloat64ArrayCid:
+      return FieldAddress(array, index, TIMES_4, Float64Array::data_offset());
+    case kUint8ArrayCid:
+      return FieldAddress(array, index, TIMES_1, Uint8Array::data_offset());
+    default:
+      UNIMPLEMENTED();
+      return FieldAddress(SPREG, 0);
+  }
+}
+
 }  // namespace dart