Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4074)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11411132: Merge 168694 - Enable fullscreen for apps windows (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1312/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller.cc
===================================================================
--- chrome/browser/ui/browser_command_controller.cc (revision 169106)
+++ chrome/browser/ui/browser_command_controller.cc (working copy)
@@ -1094,10 +1094,11 @@
command_updater_.UpdateCommandEnabled(IDC_PROFILING_ENABLED, show_main_ui);
#endif
- // Disable explicit fullscreen toggling when in metro snap mode.
- bool fullscreen_enabled = !browser_->is_type_panel() &&
- !browser_->is_app() &&
- fullscreen_mode != FULLSCREEN_METRO_SNAP;
+ // Disable explicit fullscreen toggling for app-panels and when in metro snap
+ // mode.
+ bool fullscreen_enabled =
+ !(browser_->is_type_panel() && browser_->is_app()) &&
+ fullscreen_mode != FULLSCREEN_METRO_SNAP;
#if defined(OS_MACOSX)
// The Mac implementation doesn't support switching to fullscreen while
// a tab modal dialog is displayed.
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698